Skip to content

Fix sort for size 1 axes#2106

Merged
ndgrigorian merged 2 commits intomasterfrom
fix-sorting-size-1-axes
Jul 9, 2025
Merged

Fix sort for size 1 axes#2106
ndgrigorian merged 2 commits intomasterfrom
fix-sorting-size-1-axes

Conversation

@ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Jun 18, 2025

Some sorting algorithms used (in particular radix_sort) assert that elements to be sorted must be greater than 1, and this can cause failures in debug builds, like coverage

This PR proposes a fix: copy in sort and memset to 0 in argsort when sort_nelems is 1

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions
Copy link

github-actions bot commented Jun 18, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_16 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Jun 18, 2025 •
edited
Loading

Coverage Status

coverage: 85.887% (-0.01%) from 85.898%
when pulling 9246251 on fix-sorting-size-1-axes
into 6f6fe50 on master.

@ndgrigorian ndgrigorian force-pushed the fix-sorting-size-1-axes branch from 6344d94 to 1838afa Compare June 18, 2025 20:04
@ndgrigorian ndgrigorian marked this pull request as ready for review June 18, 2025 20:19
@github-actions
Copy link

github-actions bot commented Jun 18, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_21 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@antonwolfy antonwolfy mentioned this pull request Jun 23, 2025
Merged
8 tasks
antonwolfy
antonwolfy previously approved these changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian for catching and resolving that

@ndgrigorian ndgrigorian force-pushed the fix-sorting-size-1-axes branch from 1838afa to 0cf8e0f Compare July 7, 2025 22:42
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_53 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@ndgrigorian ndgrigorian requested a review from antonwolfy July 7, 2025 23:58
@ndgrigorian
Copy link
Collaborator Author

ndgrigorian commented Jul 7, 2025

@antonwolfy
I've added assertions that iter_nelems is the count of elements in the destination array, for safety

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_54 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@ndgrigorian ndgrigorian merged commit e2789db into master Jul 9, 2025
79 of 99 checks passed
@ndgrigorian ndgrigorian deleted the fix-sorting-size-1-axes branch July 9, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ndgrigorian @coveralls @antonwolfy